Test-debt batch: cider-log/cider-repl coverage, shadow-cljs re-enable#4074
Merged
Conversation
cider-log-kill-appender's message had the appender and framework swapped, cider-log-buffer-clear-p read as the opposite of its behavior (now cider-log-buffer-has-content-p, old name aliased), and two docstrings were copy-paste leftovers.
cider-log's 61KB got by on 16 specs; now 47, covering the dict accessors, request construction, state builders and the event display path. cider-repl grows specs for the recently added rich-content surface (verbatim emitter, html handler, external-body buttons, the handler alist) plus the Babashka/basic banner fallbacks.
It was disabled in March because shadow-cljs 2.20.13 broke against nREPL 1.6's wrap-describe arity change; current shadow-cljs releases are built against modern nREPL. Passes locally in ~28s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-2.0 safety-net work:
cider-loggoes from 16 to 47 specs (dict accessors, request construction, state builders, event display path) andcider-replgains coverage for the recently added rich-content surface plus the banner fallbacks (full suite: 999 -> 1041 specs).cider-logblemishes, fixed in the first commit: a confirmation message with its arguments swapped,cider-log-buffer-clear-preading as the opposite of its behavior (renamed, old name aliased), and two copy-paste docstrings.Companion orchard PR clojure-emacs/orchard#407 (already merged) covered that repo's untested namespaces.